Implemented @communityhubnl added by default?

More
2 years 7 months ago - 2 years 7 months ago #1711 by Jip Jonker
@communityhubnl added by default? was created by Jip Jonker
Hi!

I noticed that @communityhubnl is added by default when we don't have a Twitter account to add. Why can we not leave this empty? I don't think this ia a reduired tag?
Code:
<meta name="twitter:site" content="@communityhubnl" />

Kind regards,
Jip

Download link to test version:
This message contains confidential information
Last edit: 2 years 7 months ago by Ruud van Lent. Reason: Added download link
The topic has been locked.
More
2 years 7 months ago #1714 by Ruud van Lent
Replied by Ruud van Lent on topic @communityhubnl added by default?
Hi, it is adviced to set the tags, I set my own so people see how it should be set. Got a lot of support requests in the beginning of the plugin where the @ was omitted. So it is set as an example. You should set your own Twitter account in the config.
Regards, Ruud
The topic has been locked.
More
2 years 7 months ago #1717 by Jip Jonker
Replied by Jip Jonker on topic @communityhubnl added by default?
But am I correct that leaving it empty and saving will bring back this example? Should we not be able to save an empty value that will leave the meta tag out? We don't always know the account a website owner uses or they don;t have a twitter account. But even then we would want users to be able to share it on Twitter.
The topic has been locked.
More
2 years 7 months ago #1726 by Ruud van Lent
Replied by Ruud van Lent on topic @communityhubnl added by default?
Hi Jip,
I have thought this over and see the bebefits of your use case. The twitter:site metatag is not required so leving it empty could as well omit this tag.

I will refactor it so that it will be:
1. field empty > no twitter:site tag
2. field filled but not starting with @ > prepend @ and set twitter:site

I willl also add another tag with the same logic: twitter:creator

Will do this when back from holidays and as part of making this plugin J4 (final) compatible

Thanks for your feedback!
regards,
Ruud.
The topic has been locked.
More
2 years 7 months ago #1742 by Ruud van Lent
Replied by Ruud van Lent on topic @communityhubnl added by default?
Hi Jip,

just refactored the plugin so that when the twitter account is left emtpry the twitter:site tag will NOT be set.
I have also added another metatag: twitter:creator.

the value for this tag comes from the author of the article. You need to create a Custom User Field type text for this. The user can then fill in themselves their twitter account.

I will add a download link in the first post of this thread.
You can install that version over the already installed version. When new version is released it will update automaticall via the Joomla one click update function. if for some reason it doesn't work, you can just install the previous verion over it :)
The topic has been locked.
More
2 years 6 months ago #1747 by Jip Jonker
Replied by Jip Jonker on topic @communityhubnl added by default?
Hoi Ruud! Ik was niet eerder in de gelegenheid om dit te testen en nu lijkt de download link te zijn verlopen ;-) Kun je me de dev versie nog een keer doorgeven dan probeer ik het uit.
The topic has been locked.
More
2 years 6 months ago #1748 by Ruud van Lent
Replied by Ruud van Lent on topic @communityhubnl added by default?
Hoi Jip,
het werkt :)
Ik be as-we-speak een nieuwe release aan het voorbereiden, komt er zo aan (versie 1.7.0)
The topic has been locked.
More
2 years 6 months ago #1766 by Jip Jonker
Replied by Jip Jonker on topic @communityhubnl added by default?
Thanks Ruud!
The topic has been locked.