No bug Checkout: Uncaught TypeError if to click on Plus/Minus icons
- Dmitrijs Rekuns
-
Topic Author
- Offline
Less
More
- Posts: 177
- Thank you received: 8
1 week 1 day ago #3562
by Dmitrijs Rekuns
Checkout: Uncaught TypeError if to click on Plus/Minus icons was created by Dmitrijs Rekuns
Hi Ruud,
I noticed some little problems on the checkout page at norrnext.com:
1. When a user clicks on Plus or Minus icons, there is a problem in browser console:
2. No Plus/Minus icons appear.
We do not use any template overrides for OchSubscriptions. Bootstrap and Font Awesome loaded.
Btw, these bugs were earlier. before the recent update that been released today.
Regards,
Eugene
I noticed some little problems on the checkout page at norrnext.com:
1. When a user clicks on Plus or Minus icons, there is a problem in browser console:
Uncaught TypeError: can't access property "querySelectorAll", getMessageContainer(...) is null removeMessages messages.min.js:4 renderMessages messages.min.js:4 onSuccess checkout.js:949 onreadystatechange core.min.js:4 o core.min.js:4 request core.min.js:4 doCheckoutTask checkout.js:850 doUpdateProduct checkout.js:767 onclick checkout:1
2. No Plus/Minus icons appear.
We do not use any template overrides for OchSubscriptions. Bootstrap and Font Awesome loaded.
Btw, these bugs were earlier. before the recent update that been released today.
Regards,
Eugene
The topic has been locked.
- Ruud van Lent
-
- Offline
Less
More
- Posts: 1858
- Thank you received: 122
1 week 1 day ago - 1 week 1 day ago #3563
by Ruud van Lent
Replied by Ruud van Lent on topic Checkout: Uncaught TypeError if to click on Plus/Minus icons
in ochSubscriptions config > advanced setting > Load Joomla Messages script on checkout page, can you turn that on and see if that fixes the issue?
ochSubscriptions is calling core joomla JS to display the system messages (in the templates 'system-message-container' div. this should be provided by the template. When clicking the + or - then a system message is displayed via core Joomla JS but because that container is not present, the script will 'fail'.
No experience with Yootheme so do not know why they not use that div etc.
and as you can see the error is thrown by Core Joomla messages.js not ochSubscriptions.
ochSubscriptions is calling core joomla JS to display the system messages (in the templates 'system-message-container' div. this should be provided by the template. When clicking the + or - then a system message is displayed via core Joomla JS but because that container is not present, the script will 'fail'.
No experience with Yootheme so do not know why they not use that div etc.
and as you can see the error is thrown by Core Joomla messages.js not ochSubscriptions.
Last edit: 1 week 1 day ago by Ruud van Lent.
The topic has been locked.
- Ruud van Lent
-
- Offline
Less
More
- Posts: 1858
- Thank you received: 122
1 week 1 day ago #3564
by Ruud van Lent
Replied by Ruud van Lent on topic Checkout: Uncaught TypeError if to click on Plus/Minus icons
In the installation package the icons got removed (change in my build system :S). I have re-added them in ochSubscriptions Package 5.4.1
you can redownload that version and install over the current ochSubscriptions Package 5.4.1 you have installed now: the + - icons etc. should then show again.
you can redownload that version and install over the current ochSubscriptions Package 5.4.1 you have installed now: the + - icons etc. should then show again.
The topic has been locked.
- Dmitrijs Rekuns
-
Topic Author
- Offline
Less
More
- Posts: 177
- Thank you received: 8
1 week 1 day ago - 1 week 1 day ago #3565
by Dmitrijs Rekuns
Replied by Dmitrijs Rekuns on topic Checkout: Uncaught TypeError if to click on Plus/Minus icons
Oh, thank you for the idea what to have a look at.
I disabled load Joomla messages but it did not help.
However, we have override for Joomla messages in Yootheme Pro template and this causes the conflict.
And here is that override (code):
yootheme.com/support/question/171239
I have to investigate this solution more.
Thank you for the advice!
I disabled load Joomla messages but it did not help.
However, we have override for Joomla messages in Yootheme Pro template and this causes the conflict.
And here is that override (code):
yootheme.com/support/question/171239
I have to investigate this solution more.
Thank you for the advice!
Last edit: 1 week 1 day ago by Dmitrijs Rekuns.
The topic has been locked.
- Ruud van Lent
-
- Offline
Less
More
- Posts: 1858
- Thank you received: 122
1 week 1 day ago #3566
by Ruud van Lent
Replied by Ruud van Lent on topic Checkout: Uncaught TypeError if to click on Plus/Minus icons
That must be it then.
Joomla core looks for this div via it's ID
you can add that container yourself to the page, or if the Yootheme message container doesn't have an ID you can maybe add the Joomla ID?
PS: do not forget to re-download the package 5.4.1 again from the website as that has the missing icons.css
Joomla core looks for this div via it's ID
Code:
<div id="system-message-container" aria-live="polite"></div>
you can add that container yourself to the page, or if the Yootheme message container doesn't have an ID you can maybe add the Joomla ID?
PS: do not forget to re-download the package 5.4.1 again from the website as that has the missing icons.css
The topic has been locked.
- Dmitrijs Rekuns
-
Topic Author
- Offline
Less
More
- Posts: 177
- Thank you received: 8
1 week 1 day ago - 1 week 1 day ago #3567
by Dmitrijs Rekuns
Replied by Dmitrijs Rekuns on topic Checkout: Uncaught TypeError if to click on Plus/Minus icons
The final solution — I added a fallback for Joomla.renderMessages that intercepts calls from OCH and displays them via UIkit notifications. It’s now working.
The icons appear now.
Thanks a lot, Ruud!
The ticket can be closed now.
The icons appear now.
Thanks a lot, Ruud!
The ticket can be closed now.
Last edit: 1 week 1 day ago by Dmitrijs Rekuns.
The topic has been locked.
- Ruud van Lent
-
- Offline
Less
More
- Posts: 1858
- Thank you received: 122
1 week 1 day ago #3568
by Ruud van Lent
Replied by Ruud van Lent on topic Checkout: Uncaught TypeError if to click on Plus/Minus icons
thanks for reporting back!
closing now.
feel free to open a new topic when you have other issues / questions.
regards,
Ruud
closing now.
feel free to open a new topic when you have other issues / questions.
regards,
Ruud
The topic has been locked.