Confirmed Paypal onWebHook potential problem
- Alex Chartier
-
Topic Author
- Offline
Less
More
- Posts: 66
- Thank you received: 0
5 days 17 hours ago #3608
by Alex Chartier
Paypal onWebHook potential problem was created by Alex Chartier
Hi Ruud,
Just happened to notice that in the onWebHook function you test whether there is a request and orderID in the response. If either are not there you log an error but then the code falls through which I am not sure you want to do.
Just thought I would mention it.
Cheers.
Just happened to notice that in the onWebHook function you test whether there is a request and orderID in the response. If either are not there you log an error but then the code falls through which I am not sure you want to do.
Just thought I would mention it.
Cheers.
Please Log in to join the conversation.
- Ruud van Lent
-
- Offline
Less
More
- Posts: 1873
- Thank you received: 123
5 days 1 hour ago #3609
by Ruud van Lent
Replied by Ruud van Lent on topic Paypal onWebHook potential problem
Hi Alex,
good catch: currently testing with a 'close' after the error.
for the working it will not make a difference as when these variables are not set the webhook will stop anyway in a later stage: but stopping early will save a roundtrip to the PayPal API.
good catch: currently testing with a 'close' after the error.
for the working it will not make a difference as when these variables are not set the webhook will stop anyway in a later stage: but stopping early will save a roundtrip to the PayPal API.
Please Log in to join the conversation.